Skip to content

Standarize Mock Request Paths #17449

Open
@jzheaux

Description

@jzheaux

Historically, Spring Security tests have set the servlet path to indicate the path of a MockHttpServletRequest. This was needed for AntPath and MvcRequestMatcher to correctly match the specified request path.

This can leave MockHttpServletRequest in an inconsistent state since requestURI is null while servletPath has a value.

For example, PathPatternRequestMatcher does not use the servlet path. For tests to continue working both before and after the migration from AntPath/MvcRequestMatcher to PathPatternRequestMatcher, the mock requests should have a consistent representation of path in getRequestURI and getServletPath.

This ticket should ensure that the requestURI and servletPath have consistent values in Spring Security tests.

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)type: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions