Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support POST method for ServerRedirectStrategy #16542

Open
sjohnr opened this issue Feb 5, 2025 · 5 comments · May be fixed by #16551
Open

Support POST method for ServerRedirectStrategy #16542

sjohnr opened this issue Feb 5, 2025 · 5 comments · May be fixed by #16551
Assignees
Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@sjohnr
Copy link
Member

sjohnr commented Feb 5, 2025

This is the reactive counterpart to gh-13002. See gh-16214.

@sjohnr sjohnr added in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement labels Feb 5, 2025
@sjohnr sjohnr self-assigned this Feb 5, 2025
@franticticktick
Copy link
Contributor

Hi @sjohnr, could you assign this ticket to me please?

@kiruthiga1793
Copy link

Hi @sjohnr , I am also interested if you need additional hands.

@sjohnr
Copy link
Member Author

sjohnr commented Feb 6, 2025

Thanks folks, you are quick! I'll assign to @franticticktick but please feel free to review and give feedback, @kiruthiga1793.

@sjohnr sjohnr assigned franticticktick and unassigned sjohnr Feb 6, 2025
@franticticktick
Copy link
Contributor

@sjohnr I noticed that in OidcClientInitiatedServerLogoutSuccessHandler redirectStrategy this is a final field. I can remove final in a separate commit and add setRedirectStrategy, otherwise ServerFormPostRedirectStrategy doesn’t make much sense.

franticticktick added a commit to franticticktick/spring-security that referenced this issue Feb 7, 2025
@franticticktick franticticktick linked a pull request Feb 7, 2025 that will close this issue
@sjohnr
Copy link
Member Author

sjohnr commented Feb 7, 2025

Thanks for pointing that out, @franticticktick. I think it might be nice to have that enhancement tracked in either a separate issue or a separate PR so that it shows up as its own line in release notes. A PR is enough, so feel free to open one for that and reference this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants