Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapToUser/mapToGrantedAuthority in JdbcUserDetailsManager to become protected #16540

Open
flozano opened this issue Feb 5, 2025 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@flozano
Copy link

flozano commented Feb 5, 2025

Expected Behavior

I'd like to be able to override mapToUser and mapToGrantedAuthority in order to be able to customize how the user is mapped and what's the actual class to be used, and what's the instance of GrantedAuthority to be used.

Current Behavior

	private UserDetails mapToUser(ResultSet rs, int rowNum) throws SQLException {

Context
JdbcUserDetailsManager is not final and can be extended to override some of its behavior. It already has protected methods. By making this one protected, the extensibility can be much simplified.

The loadUsersByUsername is protected and can be extended already, so this is a minimal change.

@flozano flozano added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 5, 2025
@flozano flozano changed the title mapToUser in JdbcUserDetailsManager to become protected mapToUser/mapToGrantedAuthority in JdbcUserDetailsManager to become protected Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant