@ApplicationModuleTest not inheriting the @Import classes from Base Test

[sivaprasadreddy]

Until Spring Modulith 2.0.0 the following test setup is working fine.

@Import(TestcontainersConfiguration.class)
@AutoConfigureMockMvc
public abstract class AbstractIntegrationTest {
    @Autowired
    protected MockMvcTester mockMvcTester;
}


@ApplicationModuleTest(
        webEnvironment = RANDOM_PORT,
        mode = DIRECT_DEPENDENCIES,
        extraIncludes = {"config", "users"})
class AdminBooksControllerTests extends AbstractIntegrationTest {
    //tests
}

But when I upgrade to Spring Modulith 2.0.1 or 2.0.2, the TestcontainersConfiguration is not considered and failed with the following error:

WARN  org.springframework.boot.web.server.servlet.context.AnnotationConfigServletWebServerApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'com.sivalabs.bookstore.common.TestcontainersConfiguration' available

I can work around this by simply adding @Import(TestcontainersConfiguration.class) to all the tests like AdminBooksControllerTests. But instead of duplicating the configuration, I would prefer to have it in parent base test and work as it used to in Spring Modulith 2.0.0.

PS: Reproducer repo https://github.com/sivaprasadreddy/bookstore

More context:
The TestcontainersConfiguration and AbstractIntegrationTest are in common package com.sivalabs.bookstore.common and AdminBooksControllerTests is in com.sivalabs.bookstore.admin.web package then it is failing. However, if I move TestcontainersConfiguration and AbstractIntegrationTest to the base package com.sivalabs.bookstore then its working fine.

[odrotbohm]

The build succeeds if I run ./mvnw clean verify.

[sivaprasadreddy]

Sorry, I committed the changes after moving TestcontainersConfiguration and AbstractIntegrationTest to the base package com.sivalabs.bookstore. I reverted the changes. Please check once.

[odrotbohm]

The reason you don't see the TestcontainersConfiguration applied is that it resides in a module not included in the test run as you bootstrap AdminBooksControllerTests in the direct dependencies mode. There are no bean dependencies from any of the modules involved in the run, which causes the code in commons be ignored completely as we only consider the production sources when selecting code for inclusion.

You can work around this issue by adding @Modulithic(sharedModules = "commons") to BookStoreApplication to make sure that it's always included in any application module test.

That said, I think an argument can be made that code explicitly referenced via an @Import should always be considered. I'll have to take this back to the framework team on how to detect that.

[odrotbohm]

I've pushed a tiny change that at least changes the way the problem is revealed. With it applied, you'll see the service beans reported missing, which is at least more consistent with what's going on, as it's an effect of commons not part of the test execution.