-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to prepare the pool #3072
base: main
Are you sure you want to change the base?
Conversation
@goetas Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
ad3c2ff
to
adb2b0a
Compare
@goetas Thank you for signing the Contributor License Agreement! |
Thanks for reaching out. I would consider the missing call to |
@mp911de hi and thanks for answering so quickly. I have moved the pool preparation to |
...ava/org/springframework/data/redis/connection/lettuce/LettucePoolingClientConfiguration.java
Outdated
Show resolved
Hide resolved
if this is a bug, then maybe i do not need to add an additional config? should i just call |
That's how I see it as well.
Yes, that should be sufficient. |
All changes have been done as suggested |
Hi, this is my first pull request / contribution to a Java project.
I have a need to prepare/warmup the connection pool in advance, and it seems that it was not possible before.
Would a pull request as this be accepted? If yes can can do all the needed adjustments (formatting, tests, documentation...)
This would instruct the
LettucePoolingConnectionProvider
to warmup the pool before returning the connection.Thank you!