Skip to content

Introduce AOT context sensitive VariableNameFactory #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Apr 15, 2025 · 0 comments
Closed

Introduce AOT context sensitive VariableNameFactory #3270

christophstrobl opened this issue Apr 15, 2025 · 0 comments
Assignees
@christophstrobl
Labels
theme: aot An issue related to Ahead-Of-Time processing type: enhancement A general enhancement
Milestone
4.0 M3 (2025.1.0)

Comments

@christophstrobl
Copy link
Member

We need to have a context sensitive variable name factory capable of resolving variable name clashes within generated code blocks so that temporary names do not clash with ones from the original method signature.
@christophstrobl christophstrobl added the theme: aot An issue related to Ahead-Of-Time processing label Apr 15, 2025
@christophstrobl christophstrobl self-assigned this Apr 15, 2025
@mp911de mp911de linked a pull request May 8, 2025 that will close this issue
Add LocalVariableNameFactory #3271
Closed
@mp911de mp911de added the type: enhancement A general enhancement label May 8, 2025
@mp911de mp911de added this to the 4.0 M3 (2025.1.0) milestone May 8, 2025
@mp911de mp911de mentioned this issue May 8, 2025
Closed
@mp911de mp911de closed this as completed May 8, 2025
@mp911de mp911de mentioned this issue May 9, 2025
Closed
mp911de pushed a commit that referenced this issue May 9, 2025
@christophstrobl @mp911de
Add LocalVariableNameFactory.
9565ce7 
Add a variable name factory that considers predefined names and resolves name clashes.
Expose variable name clash resolution via the generation context of a single method.

Closes #3270
Original pull request: #3271
mp911de added a commit that referenced this issue May 9, 2025
@mp911de
Polishing.
11079d6 
Refine local variable handling to logical and physical naming where the logical name is used in AOT contributor code while the physical name is rendered.

See #3270
Original pull request: #3271
mp911de added a commit that referenced this issue May 9, 2025
@mp911de
Reduce API surface, expose interfaces only.
9bd6760 
See #3270
Original pull request: #3271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
theme: aot An issue related to Ahead-Of-Time processing type: enhancement A general enhancement
Projects
None yet
Milestone
4.0 M3 (2025.1.0)
Development

Successfully merging a pull request may close this issue.

Add LocalVariableNameFactory spring-projects/spring-data-commons
2 participants
@mp911de @christophstrobl