Skip to content

Commit 59ab73f

Browse files
committed
Change default behavior of SkipToRelevant
1 parent 06ddf28 commit 59ab73f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
* Adds equality to `PrefixInfo` class
66
* Fixes parse error if external reference file path contains a space (`='C:\My Dir\[file.xlsx]Sheet'!A1`)
7-
* Adds an option to `ExcelFormulaParser.SkipToRelevant` to not skip reference nodes which do not contain a prefix
8-
7+
* `ExcelFormulaParser.SkipToRelevant` no longer skips references without a prefix.
8+
<br> This is a breaking change, but the old behavior is arguably a bug. An argument is added to restore old behavior, defaults to new behavior.
99

1010
## 1.2.1
1111

src/XLParser/ExcelFormulaParser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ public static IEnumerable<ParseTreeNode> GetReferenceNodes(this ParseTreeNode in
384384
/// * Parentheses
385385
/// * Reference nodes which are just wrappers
386386
/// </remarks>
387-
public static ParseTreeNode SkipToRelevant(this ParseTreeNode input, bool skipReferencesWithoutPrefix = true)
387+
public static ParseTreeNode SkipToRelevant(this ParseTreeNode input, bool skipReferencesWithoutPrefix = false)
388388
{
389389
while (true)
390390
{

0 commit comments

Comments
 (0)