-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#qr-bill h1 CSS is missing line-height reset #237
Labels
bug
Something isn't working
Comments
Thank you! |
sprain
removed
the
needs reproduction
The issue cannot yet be reproduced reliably
label
Oct 24, 2023
Sorry for late reply, this change is fixing the problem we also had. Thanks for #238 change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All other elements in CSS have line-height reset except
#qr-bill h1
element. Because of that h1 page CSS line-height rule will be applied which can produce unexpected result - like in my case h1 been pushed to bottom by some pixels and not aligned with top of the bill.For me adding
#qr-bill h1 { line-height: 1; }
rule was enough to fix this and it produces the same visual result like on qt bill example image on php-swiss-qr-bill github home page.Not sure is
line-height: 1;
is enough or some more specif value should be used - I don't think h1 label will be long enough to break into multiple lines, but even in that case h1 element with line-height 1 looks good (I've tested it in browser).The text was updated successfully, but these errors were encountered: