Skip to content

Commit bf08d52

Browse files
authoredDec 15, 2024
[.github/workflows] update build/release workflow to use IRSA (#33)
1 parent 108810d commit bf08d52

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed
 

‎.github/actions/release/action.yml

+10-8
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@ name: 'Release Action'
22
description: 'Build and Push the application docker image'
33

44
inputs:
5-
aws-access-key-id:
6-
description: 'AWS Access Key ID'
7-
required: true
8-
aws-secret-access-key:
9-
description: 'AWS Secret Access Key'
5+
aws-role-to-assume:
6+
description: 'AWS Role to Assume'
107
required: true
118
public-registry-id:
129
description: 'Public ECR Registry ID'
@@ -22,12 +19,17 @@ runs:
2219
- name: Set up Docker Buildx
2320
uses: docker/setup-buildx-action@v2
2421

22+
- name: configure aws credentials
23+
uses: aws-actions/configure-aws-credentials@v1.7.0
24+
with:
25+
role-to-assume: ${{ inputs.aws-role-to-assume }}
26+
role-session-name: ${{ inputs.aws-role-session-name }}
27+
aws-region: us-east-1
28+
2529
- name: Login to Amazon ECR
26-
uses: docker/login-action@v1
30+
uses: docker/login-action@v3
2731
with:
2832
registry: public.ecr.aws
29-
username: ${{ inputs.aws-access-key-id }}
30-
password: ${{ inputs.aws-secret-access-key }}
3133

3234
- name: Build images
3335
run: make -f .github/actions/release/Makefile build

‎.github/workflows/cicd.yaml

+9-4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ on:
88
- ocean-spark
99

1010

11+
permissions:
12+
contents: read
13+
pull-requests: read
14+
id-token: write
15+
1116
jobs:
1217
ci:
1318
runs-on: ubuntu-latest
@@ -41,8 +46,8 @@ jobs:
4146
- name: release to dev
4247
uses: ./.github/actions/release
4348
with:
44-
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
45-
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
49+
aws-role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
50+
aws-role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }}
4651
public-registry-id: n8e8v3t5
4752

4853
cd-prod:
@@ -56,6 +61,6 @@ jobs:
5661
- name: release to prod
5762
uses: ./.github/actions/release
5863
with:
59-
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
60-
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
64+
aws-role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
65+
aws-role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }}
6166
public-registry-id: f4k1p1n4

0 commit comments

Comments
 (0)