Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Research container usage in IT's and add README.md #689

Open
sming opened this issue Aug 29, 2020 · 0 comments
Open

Research container usage in IT's and add README.md #689

sming opened this issue Aug 29, 2020 · 0 comments
Assignees
Labels
codebase quality high level issues pertaining to improvements / problems with the codebase's quality component:all an issue that pertains to the whole codebase level:intermediate type:documentation

Comments

@sming
Copy link
Contributor

sming commented Aug 29, 2020

add the README.md to in /heroic/heroic-test.

Focus on ES container as well to make sure we understand how/where/what we're using.

Are CI and running it locally identical?

See fb4b2d2?w=1 - this PR introduced containers it's thought.

Also see org.testcontainers.containers.GenericContainer usage in /Users/peter/src/spotify/heroic/metric/bigtable/src/test/java/com/spotify/heroic/metric/bigtable/BigtableBackendIT.java

Also see heroic/heroic-dist/src/test/java/com/spotify/heroic/PubSubConsumerIT.java .

@sming sming self-assigned this Aug 29, 2020
@sming sming added codebase quality high level issues pertaining to improvements / problems with the codebase's quality component:all an issue that pertains to the whole codebase level:intermediate type:documentation labels Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
codebase quality high level issues pertaining to improvements / problems with the codebase's quality component:all an issue that pertains to the whole codebase level:intermediate type:documentation
Projects
None yet
Development

No branches or pull requests

1 participant