Merge pull request #68 from spotahome/devops-785-add-persistance

Add Persistence to Redis pods

Author: jchanam

Makefile

@@ -1,4 +1,4 @@
-VERSION := 0.3.0
+VERSION := 0.4.0
 
 # Name of this service/application
 SERVICE_NAME := redis-operator
@@ -144,6 +144,6 @@ endif
 
 # Generate kubernetes code for types..
 .PHONY: update-codegen
-update-codegen: build
+update-codegen: docker-build
 	@echo ">> Generating code for Kubernetes CRD types..."
 	docker run --rm -v $(PWD):/go/src/github.com/spotahome/redis-operator/ $(REPOSITORY)-dev /bin/bash -c '$(UPDATE_CODEGEN_CMD)'

README.md

@@ -36,9 +36,9 @@ helm install --name redisfailover charts/redisoperator
 ## Usage
 Once the operator is deployed inside a Kubernetes cluster, a new API will be accesible, so you'll be able to create, update and delete redisfailovers.
 
-In order to deploy a new redis-failover a [specification](example/redisfailover.yaml) has to be created:
+In order to deploy a new redis-failover a [specification](example/redisfailover/all-options.yaml) has to be created:
 ```
-kubectl create -f https://raw.githubusercontent.com/spotahome/redis-operator/master/example/redisfailover.yaml
+kubectl create -f https://raw.githubusercontent.com/spotahome/redis-operator/master/redisfailover/all-options.yaml
 ```
 
 This redis-failover will be managed by the operator, resulting in the following elements created inside Kubernetes:
@@ -51,6 +51,13 @@ This redis-failover will be managed by the operator, resulting in the following
 
 **NOTE**: `NAME` is the named provided when creating the RedisFailover.
 
+### Persistance
+The operator has the ability of add persistance to Redis data. By default an `emptyDir` will be used, so the data is not saved.
+
+In order to have persistance, a PersistentVolumeClaim usage is allowed. The full [PVC definition has to be added](example/redisfailover/persistant-storage.yaml) to the Redis Failover Spec under the `Storage` section.
+
+**IMPORTANT**: By default, the persistent volume claims will be deleted when the Redis Failover is. If this is not the expected usage, a `keepAfterDeletion` flag can be added under the `storage` section of Redis. [An example is given](example/redisfailover/persistant-storage-no-pvc-deletion.yaml).
+
 ### Connection
 In order to connect to the redis-failover and use it, a [Sentinel-ready](https://redis.io/topics/sentinel-clients) library has to be used. This will connect through the Sentinel service to the Redis node working as a master.
 The connection parameters are the following:

api/redisfailover/v1alpha2/types.go

@@ -43,7 +43,7 @@ type RedisSettings struct {
 	Image           string                 `json:"image,omitempty"`
 	Version         string                 `json:"version,omitempty"`
 	ConfigMap       string                 `json:"configMap,omitempty"`
-	DataVolume      corev1.Volume          `json:"dataVolume,omitempty"`
+	Storage         RedisStorage           `json:"storage,omitempty"`
 }
 
 // SentinelSettings defines the specification of the sentinel cluster
@@ -65,6 +65,13 @@ type CPUAndMem struct {
 	Memory string `json:"memory"`
 }
 
+// RedisStorage defines the structure used to store the Redis Data
+type RedisStorage struct {
+	KeepAfterDeletion     bool                          `json:"keepAfterDeletion,omitempty"`
+	EmptyDir              *corev1.EmptyDirVolumeSource  `json:"emptyDir,omitempty"`
+	PersistentVolumeClaim *corev1.PersistentVolumeClaim `json:"persistentVolumeClaim,omitempty"`
+}
+
 // RedisFailoverStatus has the status of the cluster
 type RedisFailoverStatus struct {
 	Phase      Phase       `json:"phase"`

api/redisfailover/v1alpha2/zz_generated.deepcopy.go

@@ -25,6 +25,6 @@ spec:
     exporter: false                          # Optional. False by default. Adds a redis-exporter container to export metrics.
     exporterImage: oliver006/redis_exporter  # Optional. oliver006/redis_exporter by default.
     exporterVersion: v0.11.3                 # Optional. v0.11.3 by default.
-    dataVolume:
-      name: redis-data
-      emptyDir: {}
+    storage:
+      emptyDir: {}                           # Optional. emptyDir by default.
+