Skip to content

Commit 52ecd67

Browse files
committed
Return an empty hash as metadata when Split is disabled
1 parent 5fb05b6 commit 52ecd67

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

lib/split/helper.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ def ab_test(metric_descriptor, control = nil, *alternatives)
2929
end
3030

3131
if block_given?
32-
yield(alternative, (trial.metadata if trial))
32+
metadata = trial ? trial.metadata : {}
33+
yield(alternative, metadata)
3334
else
3435
alternative
3536
end

spec/helper_spec.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,17 @@
216216
meta
217217
end).to eq('Meta1')
218218
end
219+
220+
it 'should pass empty hash to helper block if library disabled' do
221+
Split.configure do |config|
222+
config.enabled = false
223+
end
224+
225+
expect(ab_test('my_experiment')).to eq 'one'
226+
expect(ab_test('my_experiment') do |_, meta|
227+
meta
228+
end).to eq({})
229+
end
219230
end
220231

221232
describe 'finished' do

0 commit comments

Comments
 (0)