Skip to content

Commit d46a130

Browse files
mmelogranommelograno
authored
Merge pull request #38 from splitio/feature/semver
Feature/semver
2 parents ae80227 + 80850bb commit d46a130

28 files changed

+111
-87
lines changed

‎.github/pull_request_template.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# SPLIT DAEMON
2+
3+
## What did you accomplish?
4+
<!-- A brief explanation synthesizing the feature, bug or fix. -->
5+
- [ ] Bug fix
6+
- [ ] New feature
7+
- [ ] Breaking change
8+
9+
## How do we test the changes introduced in this PR?
10+
11+
## Extra Notes

‎.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727

2828
- name: Version validation
2929
if: ${{ github.event_name == 'pull_request' }}
30-
uses: mukunku/tag-exists-action@v1.5.0
30+
uses: mukunku/tag-exists-action@v1.6.0
3131
id: checkTag
3232
with:
3333
tag: v${{ env.VERSION }}
@@ -55,7 +55,7 @@ jobs:
5555
run: make binaries_release
5656

5757
- name: SonarQube Scan
58-
uses: SonarSource/sonarcloud-github-action@v2.0.0
58+
uses: SonarSource/sonarcloud-github-action@v2.1.1
5959
env:
6060
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
6161
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -67,14 +67,14 @@ jobs:
6767
6868
- name: Git tag
6969
if: ${{ github.event_name == 'push' }}
70-
uses: mathieudutour/github-tag-action@v6.1
70+
uses: mathieudutour/github-tag-action@v6.2
7171
with:
7272
github_token: ${{ secrets.GITHUB_TOKEN }}
7373
custom_tag: ${{ env.VERSION }}
7474
tag_prefix: 'v'
7575

7676
- name: Release
77-
uses: softprops/action-gh-release@v1
77+
uses: softprops/action-gh-release@v2
7878
if: ${{ github.event_name == 'push' }}
7979
with:
8080
name: splitd-${{ env.VERSION }}

‎CHANGES

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
1.4.0 (May 14, 2024):
2+
- Updated go-split-commons to v6
3+
- Added support for targeting rules based on semantic versions (https://semver.org/).
4+
- Added the logic to handle correctly when the SDK receives an unsupported Matcher type.
5+
16
1.3.1 (March 4, 2024):
27
- Add socat in runner image
38

‎external/commons/mocks/evaluator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package mocks
22

33
import (
4-
"github.com/splitio/go-split-commons/v5/engine/evaluator"
4+
"github.com/splitio/go-split-commons/v6/engine/evaluator"
55
"github.com/stretchr/testify/mock"
66
)
77

‎external/commons/mocks/impmanager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package mocks
22

33
import (
4-
"github.com/splitio/go-split-commons/v5/dtos"
5-
"github.com/splitio/go-split-commons/v5/provisional"
4+
"github.com/splitio/go-split-commons/v6/dtos"
5+
"github.com/splitio/go-split-commons/v6/provisional"
66
"github.com/stretchr/testify/mock"
77
)
88

‎external/commons/mocks/imprecorder.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package mocks
22

33
import (
4-
"github.com/splitio/go-split-commons/v5/dtos"
5-
"github.com/splitio/go-split-commons/v5/service"
4+
"github.com/splitio/go-split-commons/v6/dtos"
5+
"github.com/splitio/go-split-commons/v6/service"
66
"github.com/stretchr/testify/mock"
77
)
88

‎external/commons/mocks/splitstorage.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package mocks
22

33
import (
4-
"github.com/splitio/go-split-commons/v5/dtos"
5-
"github.com/splitio/go-split-commons/v5/storage"
4+
"github.com/splitio/go-split-commons/v6/dtos"
5+
"github.com/splitio/go-split-commons/v6/storage"
66
"github.com/splitio/go-toolkit/v5/datastructures/set"
77
"github.com/stretchr/testify/mock"
88
)
@@ -63,4 +63,9 @@ func (m *SplitStorageMock) GetNamesByFlagSets(sets []string) map[string][]string
6363
return args.Get(0).(map[string][]string)
6464
}
6565

66+
func (m *SplitStorageMock) GetAllFlagSetNames() []string {
67+
args := m.Called()
68+
return args.Get(0).([]string)
69+
}
70+
6671
var _ storage.SplitStorage = (*SplitStorageMock)(nil)

‎go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ module github.com/splitio/splitd
33
go 1.21
44

55
require (
6-
github.com/splitio/go-split-commons/v5 v5.1.0
7-
github.com/splitio/go-toolkit/v5 v5.3.2
6+
github.com/splitio/go-split-commons/v6 v6.0.0
7+
github.com/splitio/go-toolkit/v5 v5.4.0
88
github.com/stretchr/testify v1.8.1
99
github.com/vmihailenco/msgpack/v5 v5.3.5
1010
golang.org/x/sync v0.3.0

‎go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
77
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
88
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
99
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
10-
github.com/splitio/go-split-commons/v5 v5.1.0 h1:mki1235gjXwuxcXdv/bKVduX1Lv09uXJogds+BspqSM=
11-
github.com/splitio/go-split-commons/v5 v5.1.0/go.mod h1:9vAZrlhKvhensyRC11hyVFdgLIBrkX9D5vdYc9qB13w=
12-
github.com/splitio/go-toolkit/v5 v5.3.2 h1:Yy9YBcHRmK5WVZjeA/klLGEdF38xpsL1ejnC3ro8a2M=
13-
github.com/splitio/go-toolkit/v5 v5.3.2/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
10+
github.com/splitio/go-split-commons/v6 v6.0.0 h1:qenr5qbXafjvM832C64CVpjtlShuQiWCwtR5I2h4ogM=
11+
github.com/splitio/go-split-commons/v6 v6.0.0/go.mod h1:TsvIh3XP7yjc7ly4vpj06AkoBND36SodPs5qfhb8rHc=
12+
github.com/splitio/go-toolkit/v5 v5.4.0 h1:g5WFpRhQomnXCmvfsNOWV4s5AuUrWIZ+amM68G8NBKM=
13+
github.com/splitio/go-toolkit/v5 v5.4.0/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
1414
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
1515
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
1616
github.com/stretchr/objx v0.5.0 h1:1zr/of2m5FGMsad5YfcqgdqdWrIhu+EBEJRhR1U7z/c=

‎splitio/link/client/types/interfaces.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package types
22

33
import (
4-
"github.com/splitio/go-split-commons/v5/dtos"
4+
"github.com/splitio/go-split-commons/v6/dtos"
55
"github.com/splitio/splitd/splitio/sdk"
66
)
77

0 commit comments

Comments
 (0)