Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team select problem #245

Open
iRonicro opened this issue Mar 17, 2020 · 19 comments
Open

Team select problem #245

iRonicro opened this issue Mar 17, 2020 · 19 comments

Comments

@iRonicro
Copy link

  • Plugin version: CS:GO Multi1v1 (1.1.9) by splewis
  • Sourcemod version: sourcemod-1.10.0.6478
  • Steps to reproduce (please be specific): Team menu is not working corectly, after what i join in team this "team menu" still reamaining open, i think is because of Event_OnPlayerTeam (if i disable thsi public.. the team select is working fine but have other problems)
public Action Event_OnPlayerTeam(Event event, const char[] name, bool dontBroadcast) {
  if (!g_Enabled)
    return Plugin_Continue;

  SetEventBroadcast(event, true);
  return Plugin_Continue;
}

ezgif com-video-to-gif

@gg-cfg
Copy link

gg-cfg commented Mar 26, 2020

I have the same problem!
What are the problems after changing Event_OnPlayerTeam?
PS. sorry for my English :D

@spyrek10
Copy link

+1 also got this problem

@iRonicro
Copy link
Author

iRonicro commented Mar 27, 2020

I have the same problem!
What are the problems after changing Event_OnPlayerTeam?
PS. sorry for my English :D

You will destroy the plugin, the tags will be set random to players and few not even get that plus the default message in chat will be re-enable and every time when the server swap arena's for players in chat will be send that message for team join "x joined to terrorist team".

I tried to fix this on my own but i'm begginer in this, I did not solve anything.. i hope @splewis will fix this asm.

@Skurkur
Copy link

Skurkur commented Mar 27, 2020

Same here.
Must select team a minimum of two times, ending with ct to remove the selection overlay or press ESC after selection.
Selecting T - CT closes the overlay
Selecting T - T does not close the overlay
Selecting CT - T does not close the overlay
Selecting CT - CT - CT (3+, seems random) closes the overlay
Selecting CT/T - ESC closes the overlay

Metamod:Source version 1.10.7-dev
SourceMod 1.11.0.6522, by AlliedModders LLC
"CS:GO Multi1v1" (1.1.9) by splewis

@iRonicro
Copy link
Author

iRonicro commented Apr 4, 2020

@splewis any news about this ?

@gg-cfg
Copy link

gg-cfg commented Apr 5, 2020

@iRonicro nope

@crashzk
Copy link
Contributor

crashzk commented Apr 10, 2020

Same problem here, a fix would be well appreciated. 😁

@RunGuitarMan
Copy link

+1
Same problem

@MinfasCZE
Copy link

+1 really annoying, but I saw some servers without this problem.

@Ilusion9
Copy link

Ilusion9 commented Jun 10, 2020

Fix: remove (from player_team event callback)
SetEventBroadcast(event, true);
and replace with
event.SetBool("silent", true);

@iRonicro
Copy link
Author

iRonicro commented Jun 11, 2020

Fix: remove (from player_team event callback)
SetEventBroadcast(event, true);
and replace with
event.SetBool("silent", true);

I will try this tmrw, thank you.
edit: Nop is not working right (have few issues with arena's in scoreboard are not displayed correctly)

@Ilusion9
Copy link

That bug is not from this.

@iRonicro
Copy link
Author

That bug is not from this.

What sourcemod you using?

@Ilusion9
Copy link

Ilusion9 commented Jun 14, 2020

That bug is not from this.

What sourcemod you using?

* have a look here #262

doesn't matter what version. using seteventbroadcast(event, true) will always break the teammenu. use event.setbool("silent", true) and block clan tag changes:

public void OnClientPutInServer(int client)
{
	CS_SetClientClanTag(client, "");
}

public Action OnClientCommandKeyValues(int client, KeyValues kv)
{
	char command[PLATFORM_MAX_PATH];
	if (kv.GetSectionName(command, sizeof(command)) && StrEqual(command, "ClanTagChanged", false))
	{
		return Plugin_Handled;
	}
	
	return Plugin_Continue;
}

Changing clantags by this plugin will still work.

@iRonicro
Copy link
Author

iRonicro commented Jun 15, 2020

@ALL Thank you in finally works fine 👍 i will post back if some bugs show up!

@Ilusion9 Multumesc mult pentru ajutor, daca cumva cauti o comunitate de gaming da-mi add pe steam : Țicu

@splewis
Copy link
Owner

splewis commented Jun 16, 2020

As far as I know, this bug still exists in the plugin, and is still pending a fix to be checked in. Pull requests welcome.

@splewis splewis reopened this Jun 16, 2020
@crashzk
Copy link
Contributor

crashzk commented Jun 16, 2020

Fix: remove (from player_team event callback)

SetEventBroadcast(event, true);

and replace with

event.SetBool("silent", true);

@Ilusion9 could a PR do to correct this error in future updates?

@crashzk
Copy link
Contributor

crashzk commented Jun 19, 2020

I took the liberty of doing PR with the correction mentioned here by @Ilusion9:

Fix: remove (from player_team event callback)
SetEventBroadcast(event, true);
and replace with
event.SetBool("silent", true);

@xSL0W
Copy link
Contributor

xSL0W commented Oct 29, 2021

Solution:
#283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants