We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are two place where we check route uri handler using try/catch
try { $uriHandler = $route->getUriHandler(); } catch (\Throwable) { $uriHandler = $this->uriHandler; }
https://github.com/spiral/framework/blob/master/src/Router/src/RouteGroup.php#L106 https://github.com/spiral/framework/blob/master/src/Router/src/Router.php#L207
But using try catch my be slower that using proper method like $route->hasUriHandler()
$route->hasUriHandler()
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
There are two place where we check route uri handler using try/catch
https://github.com/spiral/framework/blob/master/src/Router/src/RouteGroup.php#L106
https://github.com/spiral/framework/blob/master/src/Router/src/Router.php#L207
But using try catch my be slower that using proper method like
$route->hasUriHandler()
The text was updated successfully, but these errors were encountered: