Support dropped counts

Signed-off-by: Caleb Schoepp <[email protected]>

Author: calebschoepp

crates/world/src/conversions.rs

@@ -507,8 +507,10 @@ mod otel {
         fn from(value: wasi_otel::SpanData) -> Self {
             let mut span_events = SpanEvents::default();
             span_events.events = value.events.into_iter().map(Into::into).collect();
+            span_events.dropped_count = value.dropped_events;
             let mut span_links = SpanLinks::default();
             span_links.links = value.links.into_iter().map(Into::into).collect();
+            span_links.dropped_count = value.dropped_links;
             Self {
                 span_context: value.span_context.into(),
                 parent_span_id: opentelemetry::trace::SpanId::from_hex(&value.parent_span_id)
@@ -518,7 +520,7 @@ mod otel {
                 start_time: value.start_time.into(),
                 end_time: value.end_time.into(),
                 attributes: value.attributes.into_iter().map(Into::into).collect(),
-                dropped_attributes_count: 0,
+                dropped_attributes_count: value.dropped_attributes,
                 events: span_events,
                 links: span_links,
                 status: value.status.into(),
@@ -529,7 +531,6 @@ mod otel {
 
     impl From<wasi_otel::SpanContext> for opentelemetry::trace::SpanContext {
         fn from(sc: wasi_otel::SpanContext) -> Self {
-            // TODO(Reviewer): Should this be try_from instead an propagate this error out of the WIT?
             let trace_id = opentelemetry::trace::TraceId::from_hex(&sc.trace_id)
                 .unwrap_or(opentelemetry::trace::TraceId::INVALID);
             let span_id = opentelemetry::trace::SpanId::from_hex(&sc.span_id)
@@ -557,7 +558,6 @@ mod otel {
                     .trace_state()
                     .header()
                     .split(',')
-                    // TODO(Reviewer): Should this be try_from instead an propagate this error out of the WIT?
                     .filter_map(|s| {
                         if let Some((key, value)) = s.split_once('=') {
                             Some((key.to_string(), value.to_string()))

tests/test-components/components/Cargo.lock

@@ -11,6 +11,6 @@ anyhow = "1"
 http = "0.2"
 opentelemetry = "0.27.0"
 opentelemetry_sdk = "0.27.0"
-opentelemetry-wasi = { git = "https://github.com/calebschoepp/opentelemetry-wasi", rev = "78d0cf0d1e2674591ab0dfdca8443a81a1e402bd" }
+opentelemetry-wasi = { git = "https://github.com/calebschoepp/opentelemetry-wasi", rev = "bd0fad4dd41c07a64e02fb048b2ec56dc08d19ed" }
 spin-sdk = "3.1.0"
 wit-bindgen = "0.30.0"

tests/test-components/components/wasi-otel-tracing/Cargo.toml

@@ -12,33 +12,34 @@ interface tracing {
 
     /// The data associated with a span.
     record span-data {
-        /// Span context
+        /// Span context.
         span-context: span-context,
-        /// Span parent id
-        // TODO: No clue what this is for
+        /// Span parent id.
         parent-span-id: string,
-        /// Span kind
+        /// Span kind.
         span-kind: span-kind,
-        // Span name
+        // Span name.
         name: string,
-        /// Span start time
+        /// Span start time.
         start-time: datetime,
-        /// Span end time
+        /// Span end time.
         end-time: datetime,
-        /// Span attributes
+        /// Span attributes.
         attributes: list<key-value>,
-        /// Span events
+        /// Span events.
         events: list<event>,
-        /// Span Links
+        /// Span Links.
         links: list<link>,
-        /// Span status
+        /// Span status.
         status: status,
-        /// Instrumentation scope that produced this span
+        /// Instrumentation scope that produced this span.
         instrumentation-scope: instrumentation-scope,
-
-        // TODO:
-        // - Dropped counts
-        // - parent span id vs parent span context
+        /// Number of attributes dropped by the span due to limits being reached.
+        dropped-attributes: u32,
+        /// Number of events dropped by the span due to limits being reached.
+        dropped-events: u32,
+        /// Number of links dropped by the span due to limits being reached.
+        dropped-links: u32,
     }
 
     /// Identifying trace information about a span that can be serialized and propagated.
@@ -123,11 +124,11 @@ interface tracing {
 
     /// An event describing a specific moment in time on a span and associated attributes.
     record event {
-        /// Event name
+        /// Event name.
         name: string,
-        /// Event time
+        /// Event time.
         time: datetime,
-        /// Event attributes
+        /// Event attributes.
         attributes: list<key-value>,
     }