Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mutex to ensure only one command is run #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use mutex to ensure only one command is run #226

wants to merge 1 commit into from

Conversation

faisal-memon
Copy link
Collaborator

@faisal-memon faisal-memon commented Dec 5, 2024 •
edited
Loading

The signalProcess() function wasn't using a mutex. So two consecutive calls both would see processRunning as 0. This change-set switches over to using a mutex to wrap the logic starting and monitoring the process.

fixes #209

@faisal-memon faisal-memon added this to the 0.10.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

exec race
1 participant
@faisal-memon