Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a unit test suite #2

Open
evan2645 opened this issue Sep 20, 2021 · 4 comments
Open

Develop a unit test suite #2

evan2645 opened this issue Sep 20, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@evan2645
Copy link
Member

The codebase is very small, but there are still some opportunities to cover some of the functions by unit test. Cover the functions that make sense, making minor modifications to the code if necessary.

@evan2645
Copy link
Member Author

It would be great if we could just stick to go stdlib for this

@azdagron
Copy link
Member

It would be great if we could just stick to go stdlib for this

Does this mean not pulling in something that implements convenient assertions (e.g. github.com/stretchr/testify)? or something else?

@evan2645
Copy link
Member Author

Does this mean not pulling in something that implements convenient assertions (e.g. github.com/stretchr/testify)?

This was my intention, but it's just a preference :)

@evan2645 evan2645 added the help wanted Extra attention is needed label Sep 20, 2021
@azdagron
Copy link
Member

That seems fine. The unit-tests should be small enough, this shouldn't cause too much issue. Keepin' it simple!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants