Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark stuff that shouldn't be reused #53

Open
janbrohl opened this issue Jan 19, 2020 · 3 comments
Open

Mark stuff that shouldn't be reused #53

janbrohl opened this issue Jan 19, 2020 · 3 comments

Comments

@janbrohl
Copy link
Collaborator

By @dhellmann :
We should also ensure that we are only exporting symbols we want someone else to import at the API level in the python code. Renaming some modules to prefix them with _ would signal they shouldn't be used directly.

@dhellmann
Copy link
Member

#58 is a prerequisite for this work.

@janbrohl
Copy link
Collaborator Author

Why?

@dhellmann
Copy link
Member

I figured we would want good tests in place before we start rearranging code and renaming things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants