Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesirable "merge" behavior in MAVEN and GOES load routines #916

Open
jameswilburlewis opened this issue Jul 1, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working CDF MAVEN pytplot Issues involving the pytplot package

Comments

@jameswilburlewis
Copy link
Contributor

jameswilburlewis commented Jul 1, 2024

When loading MAVEN data, load_data iterates through the CDF or STS files returned by the SDC request, then loads them one by one with merge=True. This is probably not the best implementation, since users will probably expect existing tplot variables to be replaced, not appended, when a new request is being processed.

Similarly, in the GOES load() and loadr() routines, NetCDFs are loaded one-by-one with merge=True.

It would probably be better to process the entire list of CDF, NetCDF, or STS filenames in a single call, with merge=False as the default.

See also: #911

@jameswilburlewis jameswilburlewis added bug Something isn't working pytplot Issues involving the pytplot package CDF MAVEN labels Jul 1, 2024
@jameswilburlewis jameswilburlewis changed the title Undesirable "merge" behavior in MAVEN load routines Undesirable "merge" behavior in MAVEN and GOES load routines Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CDF MAVEN pytplot Issues involving the pytplot package
Projects
None yet
Development

No branches or pull requests

2 participants