Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCP-3571 EKS Security Group tag updation from AWSManagedControlPlane #915

Merged
merged 2 commits into from
Dec 6, 2024
Merged

PCP-3571 EKS Security Group tag updation from AWSManagedControlPlane #915

merged 2 commits into from
Dec 6, 2024

Conversation

vishu2498
Copy link

What type of PR is this?

/kind feature
/kind bug

What this PR does / why we need it:

This PR implements the functionality of having the same tags everywhere in EKS cluster which are provided in spec.additionalTags section of AWSManagedControlPlane to the default cluster security group of EKS created by AWS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

For this bug: https://spectrocloud.atlassian.net/browse/PCP-3571

@vishu2498 vishu2498 requested a review from snehala27 November 25, 2024 11:28
@spectro-prow
Copy link

@vishu2498: The label(s) kind/feature, kind/bug cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind feature
/kind bug

What this PR does / why we need it:

This PR implements the functionality of having the same tags everywhere in EKS cluster which are provided in spec.additionalTags section of AWSManagedControlPlane to the default cluster security group of EKS created by AWS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

For this bug: https://spectrocloud.atlassian.net/browse/PCP-3571

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spectro-prow spectro-prow added size/L and removed size/M labels Dec 6, 2024
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snehala27, vishu2498
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jayesh-srivastava jayesh-srivastava merged commit fc87310 into spectro-master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehala27 snehala27 snehala27 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishu2498 @spectro-prow @snehala27 @jayesh-srivastava