Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectacles not picking up latest commits to branch #722

Open
ronduursma opened this issue Jun 27, 2023 · 7 comments
Open

Spectacles not picking up latest commits to branch #722

ronduursma opened this issue Jun 27, 2023 · 7 comments

Comments

@ronduursma
Copy link

After I make commits to my branch and (re)run spectacles, it doesn't seem to see my changes. Strange because this used to work before and I'm not sure what changed.

$ spectacles sql --config-file looker_dev_config.yaml --project erx-corereports --fail-fast --explores star-schema/purchase_order_item_data --port 9199 --do-not-track --branch 14638

I ran it with -v, and attached the log file. Any help appreciated.
14638.log

@DylanBaker
Copy link
Collaborator

Is there any chance you've recently changed from testing commit to testing branch?

When testing commit, it will always find the right place, but when testing branch you sometimes need to do a pull from your version control system to get the branch updates. This is done with the --remote-reset flag. Docs are here.

Could you please try that and let me know if that solves your issue? Thanks!

@ronduursma
Copy link
Author

My apologies. When I pasted the command line, I inadvertently left off the --remote-reset part. We always use it.

@DylanBaker
Copy link
Collaborator

Hmm. The logs all look like what I'd expect. Would you mind telling me about the changes that you made and what you would expect to be different from the output?

@ronduursma
Copy link
Author

Basically like this.

dimension: testfield {
...
sql: ${TABLE}.badfield ;;
}

I'll get a SQL error that badfield doesn't exist. I'll change badfield to goodfield, commit, run spectacles again with --remote-reset, but I'm still getting the error about badfield. There are no other occurrences of that. The only time this error went away was over the weekend when Looker was restarted, but since then, my commits aren't picked up by spectacles.

@DylanBaker
Copy link
Collaborator

@ronduursma Thanks for the context. Would you be able to try running this with the commit hash instead of the branch? I'm curious to see if that results in similarly incorrect behaviour, as it's unfortunately not at all clear to me what could be hpapening to cause this.

@ronduursma
Copy link
Author

@DylanBaker I tried that, using --commit-ref, and it now does the right thing. Retested with the branch just to be sure and that's still doing the wrong thing. So I can make some progress now, but that's strange.

@jschintz-windriver
Copy link

I'm seeing similar behavior with our branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants