Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close websocket handle in client #307

Open
Tracked by #269
StoicDeveloper opened this issue Sep 3, 2024 · 1 comment
Open
Tracked by #269

close websocket handle in client #307

StoicDeveloper opened this issue Sep 3, 2024 · 1 comment

Comments

@StoicDeveloper
Copy link

Ideally, the websocket could be closed both explicitly, with a client.close() method, and implicitly when the client goes out of scope.
The current implementation causes an issue in jest integration tests where a test that uses WebsocketTransport will hang forever, or until the websocket times out, and there is no way to close the socket, since the client.transport.ws field is private.

@StoicDeveloper
Copy link
Author

If you think this is a good idea, I'd be happy to submit a PR

@oscartbeaumont oscartbeaumont mentioned this issue Dec 10, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant