Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit Connector: doesn't apply ParameterUpdater using applicationId #3379

Open
samberger opened this issue May 7, 2024 · 1 comment
Open

Comments

@samberger
Copy link

samberger commented May 7, 2024

It's about the Revit Connector, when importing back a ParameterUpdater object.

"//try to get element using UniqueId" is using the elementId again, but should this be the applicationId which would be used as uniqueId for Doc.GetElement()?
As far as I understood, it's also this Revit's uniqueId, which is saved as Speckle's applicationId when uploading.

https://github.com/specklesystems/speckle-sharp/blob/b67e46c0dc3eee8572f4cf9c9cdef339949f536b/Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/UpdateParameter.cs#L30C45-L30C54

@samberger
Copy link
Author

When I adapt the ParameterUpdater properties to the given code, and use the applicationId also as elementId, it works (although it's apparently not the correct/original elementId).

grafik

@samberger samberger changed the title Should this be "applicationId"? Revit Connector: Should this be "applicationId"? May 7, 2024
@samberger samberger changed the title Revit Connector: Should this be "applicationId"? Revit Connector: doesn't apply ParameterUpdater using applicationId May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant