Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(revit): receiving parameter updater for an non-editable element does not log ui error #2717

Open
5 tasks done
dtnaughton opened this issue Jun 30, 2023 · 0 comments
Open
5 tasks done
Assignees
Labels
bug Something isn't working revit issues related to the revit connector.
Milestone

Comments

@dtnaughton
Copy link
Contributor

Prerequisites

What package are you referring to?

speckle-sharp

Describe the bug

We had a condition where a user was trying to receive an ParameterUpdater object into a model where the element was in a non-editable workset. The parameter was unable to update because of this (which triggered the error eater), but this doesn't get represented on the UI report as the application object state doesn't get updated after conversion from ParameterUpdater objs. It would be an improved user experience if these errors surface in the UI report.

Has there been consideration of checking if elements on non-editable worksets in general? I know the Revit API WorksharingUtils class has some methods exposed to check if elements are editable or not. Are these factored into conversion etc?

To Reproduce

  1. Set up model with elements on non-editable workset
  2. Receive a ParameterUpdater obj targeting an element on one of these worksets

Expected behavior

UI report should communicate error with user.

Screenshots

image

System Info

If applicable, please fill in the below details - they help a lot!

Desktop (please complete the following information):

windows

@dtnaughton dtnaughton added the bug Something isn't working label Jun 30, 2023
@teocomi teocomi added the revit issues related to the revit connector. label Jul 12, 2023
@JR-Morgan JR-Morgan added this to the 2.16 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working revit issues related to the revit connector.
Projects
No open projects
Status: 📋 To Do
Development

No branches or pull requests

4 participants