diff --git a/src/PermissionRegistrar.php b/src/PermissionRegistrar.php index c82309f8c..c3308b201 100644 --- a/src/PermissionRegistrar.php +++ b/src/PermissionRegistrar.php @@ -266,7 +266,7 @@ private function getHydratedRole(array $item) } $roleClass = $this->getRoleClass(); - $roleInstance = new $roleClass; + $roleInstance = new $roleClass(); return $this->cachedRoles[$roleId] = $roleInstance->newFromBuilder([ 'id' => $roleId, diff --git a/src/Traits/HasPermissions.php b/src/Traits/HasPermissions.php index 5ac94cbda..00b7a82ae 100644 --- a/src/Traits/HasPermissions.php +++ b/src/Traits/HasPermissions.php @@ -139,7 +139,7 @@ public function hasPermissionTo($permission, $guardName = null): bool } if (! $permission instanceof Permission) { - throw new PermissionDoesNotExist; + throw new PermissionDoesNotExist(); } return $this->hasDirectPermission($permission) || $this->hasPermissionViaRole($permission); @@ -285,7 +285,7 @@ public function hasDirectPermission($permission): bool } if (! $permission instanceof Permission) { - throw new PermissionDoesNotExist; + throw new PermissionDoesNotExist(); } return $this->permissions->contains('id', $permission->id); diff --git a/src/WildcardPermission.php b/src/WildcardPermission.php index 22d142ba0..a1b20a707 100644 --- a/src/WildcardPermission.php +++ b/src/WildcardPermission.php @@ -8,13 +8,13 @@ class WildcardPermission { /** @var string */ - const WILDCARD_TOKEN = '*'; + public const WILDCARD_TOKEN = '*'; /** @var string */ - const PART_DELIMITER = '.'; + public const PART_DELIMITER = '.'; /** @var string */ - const SUBPART_DELIMITER = ','; + public const SUBPART_DELIMITER = ','; /** @var string */ protected $permission; diff --git a/tests/HasPermissionsWithCustomModelsTest.php b/tests/HasPermissionsWithCustomModelsTest.php index 8d0ab6442..92970121a 100644 --- a/tests/HasPermissionsWithCustomModelsTest.php +++ b/tests/HasPermissionsWithCustomModelsTest.php @@ -6,7 +6,7 @@ class HasPermissionsWithCustomModelsTest extends HasPermissionsTest { /** @var bool */ protected $useCustomModels = true; - + /** @test */ public function it_can_use_custom_models() { diff --git a/tests/TestCase.php b/tests/TestCase.php index f282b915d..350d90188 100644 --- a/tests/TestCase.php +++ b/tests/TestCase.php @@ -32,7 +32,7 @@ abstract class TestCase extends Orchestra /** @var \Spatie\Permission\Models\Permission */ protected $testAdminPermission; - + /** @var bool */ protected $useCustomModels = false;