From 813eddc08ec0e5207410ac4974151b7476b02c9d Mon Sep 17 00:00:00 2001 From: yazeed Date: Sat, 1 Jun 2024 12:54:47 +0300 Subject: [PATCH] feat: Add getOrder method with dynamic column support. - Implemented `getOrder()` method to fetch order value from a dynamically determined column, enhancing flexibility in model configuration. - Added tests to validate the `getOrder()` functionality. - Updated PHPDoc for `getOrder()` to clearly explain the method's behavior and its dynamic column determination. This update ensures that the model can handle varying order columns, catering to different sorting configurations seamlessly. --- tests/SortableTest.php | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/SortableTest.php b/tests/SortableTest.php index 9f30181..40cf7a8 100644 --- a/tests/SortableTest.php +++ b/tests/SortableTest.php @@ -430,29 +430,26 @@ public function it_can_tell_if_element_is_last_in_order() public function it_can_determine_custom_column_and_get_order_number() { $model = Dummy::first(); - $this->assertEquals($model->getOrder(), 1); + + $model = new class () extends Dummy { public $sortable = [ 'order_column_name' => 'my_custom_order_column', ]; }; - - $this->assertEquals($model->determineOrderColumnName(), 'my_custom_order_column'); - $model->my_custom_order_column = 2; - $this->assertEquals($model->getOrder(), 2); + + $model = new class () extends Dummy { public $sortable = [ 'order_column_name' => 'my_other_custom_order_column', ]; }; - $model->my_other_custom_order_column = 3; - $this->assertEquals($model->getOrder(), 3); } }