diff --git a/.gitignore b/.gitignore index 93febc63..ec1bb13d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,6 @@ build composer.lock +node_modules vendor .phpunit.result.cache .php-cs-fixer.cache - diff --git a/bin/browser.cjs b/bin/browser.cjs index a554e393..0e37ae51 100644 --- a/bin/browser.cjs +++ b/bin/browser.cjs @@ -46,9 +46,10 @@ const getOutput = async (request, page = null) => { if (request.action == 'evaluate') { output.result = await page.evaluate(request.options.pageFunction); } else { - output.result = ( - await page[request.action](request.options) - ).toString('base64'); + const result = await page[request.action](request.options); + + // Ignore output result when saving to a file + output.result = request.options.path ? '' : result.toString('base64'); } } @@ -388,14 +389,14 @@ const callChrome = async pup => { await page.close(); } - await remoteInstance ? browser.disconnect() : browser.close(); + await (remoteInstance ? browser.disconnect() : browser.close()); } catch (exception) { if (browser) { if (remoteInstance && page) { await page.close(); } - (await remoteInstance) ? browser.disconnect() : browser.close(); + await (remoteInstance ? browser.disconnect() : browser.close()); } const output = await getOutput(request);