Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new element types to be used as menu items #174

Open
corymharper opened this issue Jul 17, 2020 · 3 comments · May be fixed by #325
Open

Add support for new element types to be used as menu items #174

corymharper opened this issue Jul 17, 2020 · 3 comments · May be fixed by #325
Labels
enhancement

Comments

@corymharper
Copy link
Contributor

Currently only HTMLAnchorElements are supported for use as menu item elements with the hook. For flexibility, and as not to prescribe the implementation of the hook to developers using the package, making the ref's typing more generic but still type safe would be a warranted enhancement.

This will probably require an addition of passing generic types to the hook in order to accomplish.
@WesCossick
Copy link
Member

Similar to #69.

@WesCossick WesCossick mentioned this issue Jul 17, 2020
Closed
@arty-name arty-name mentioned this issue Mar 29, 2021
Merged
@corymharper corymharper mentioned this issue Jul 22, 2021
Closed
@corymharper corymharper mentioned this issue Feb 7, 2022
Closed
@msakrejda
Copy link
Contributor

👍, a good use case for this is handling elements like react-router's Link that wrap anchor tags.

@msakrejda
Copy link
Contributor

msakrejda commented Feb 21, 2022 •
edited
Loading

Actually, because Link just renders an anchor, that's mostly moot here. But here's a different use case: menu items could be used to trigger form submission (e.g., see the log out action in this Remix example: https://remix.run/docs/en/v1/tutorials/jokes#build-logout-action -- you'll need to expand jokes.tsx).

jirutka added a commit to jirutka/react-accessible-dropdown-menu-hook that referenced this issue Oct 12, 2024
@jirutka
Allow to use any HTML Element as menu item
e4ae95f 
The code works with any HTML element, there's nothing that requires
specifically `HTMLAnchorElement` (`<a>`) except `e.currentTarget.href`
which is already conditional. Thus the current limitation is only a
typing issue introduced by unnecessarily specific `ref` type. We can
make it a generic parameter, but it wouldn't bring any real benefit,
just increase complexity and decrease flexibility.

Resolves sparksuite#174
@jirutka jirutka linked a pull request Oct 12, 2024 that will close this issue
Open
jirutka added a commit to jirutka/react-accessible-dropdown-menu-hook that referenced this issue Oct 17, 2024
@jirutka
Allow to use any HTML Element as menu item
5eaf493 
The code works with any HTML element, there's nothing that requires
specifically `HTMLAnchorElement` (`<a>`) except `e.currentTarget.href`
which is already conditional. Thus the current limitation is only a
typing issue introduced by unnecessarily specific `ref` type. We can
make it a generic parameter, but it wouldn't bring any real benefit,
just increase complexity and decrease flexibility.

Resolves sparksuite#174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to use any HTML Element as menu item jirutka/react-accessible-dropdown-menu-hook
3 participants
@msakrejda @WesCossick @corymharper