Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Change font family, size, mobile view threshold, my info page #968

Open
hye1ee opened this issue Apr 27, 2023 · 0 comments
Open

[FEAT] Change font family, size, mobile view threshold, my info page #968

hye1ee opened this issue Apr 27, 2023 · 0 comments
Assignees

Comments

@hye1ee
Copy link
Contributor

hye1ee commented Apr 27, 2023

동기

사용성 개선을 위해 스타일 일부를 아래와 같이 수정합니다.

설명

1. Font-family 수정

  • 기존) 시스템 폰트(sans-serif)
  • 제안) Noto Sans CJK KR

2. Font-size 수정

  • 기존)
  • $font-size-big: 14px;
    $line-height-big: 15px;
    $font-size-normal: 13px;
    $line-height-normal: 14px;
    $font-size-small: 12px;
    $line-height-small: 13px;
    $font-size-smaller: 11px;
    $line-height-smaller: 12px;
    $font-size-smallest: 10px;
    $line-height-smallest: 11px;
  • 제안)

3. mobile-view threshold 수정

  • 기존) 가로:세로 = 4:3
  • 제안) 가로:세로 = 2:3, 아래 사진 경로에 hardcoded 된 style존재, stylesheet로 해결 가능한지 확인하고 개선한다.
  • 스크린샷 2023-04-27 오후 10 17 23
  • portraitMediaQuery = window.matchMedia('(max-aspect-ratio: 4/3)')

4. 내 정보 > 설정 > 관심학과 정리

  • 기존) 아래 스크린샷 참고
  • 제안)

스크린샷

스크린샷 2023-04-27 오후 9 51 20

개발 환경

  • OS: [e.g. macOS]
  • python --version:
  • node --version:

테스트 환경

(OPTIONAL)

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Web Version: [e.g. 1.1.0]

추가 정보

(OPTIONAL) Add any other context or screenshots about the feature request here.

@hye1ee hye1ee self-assigned this Apr 27, 2023
@sboh1214 sboh1214 changed the title [FEAT] Style Improve [FEAT] Change font family, size, mobile view threshold, my info page Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant