Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Type Definitions: RequestMethod, RequestBody, RequestURL #1077

Open
732854690 opened this issue Dec 9, 2024 · 0 comments
Open

Missing Type Definitions: RequestMethod, RequestBody, RequestURL #1077

732854690 opened this issue Dec 9, 2024 · 0 comments

Comments

@732854690
Copy link

Hello, I noticed that the following type definitions are not available in the current version of Robyn:
• RequestMethod
• RequestBody
• RequestURL

These are mentioned in the documentation or examples, but they seem to be missing from the package. This causes type checking issues and confusion when developing with Robyn.
Steps to Reproduce
1. Use the following code snippet:
from robyn.robyn import RequestMethod, RequestBody, RequestURL
2. Run the script or check type hints in an editor (e.g., PyCharm, VS Code with type checking enabled).

Expected Behavior:
These types should be available and documented.

Actual Behavior:
Import errors occur for the above types.
Proposed Solution

Could you:
1. Add these type definitions to the library.
2. Document their expected structures (e.g., RequestMethod as Literal["GET", "POST", ...], RequestBody as Dict[str, Any], etc.).

Alternatively, if they are deprecated, it would be helpful to have updated examples or recommendations on how to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant