-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication in subroutes #1026
Comments
Hey @dave42w 👋 I agree with all of them! Yes
Yes! |
See this #889 and the links it contains. |
Hello everyone! |
Thanks @dave42w and @IA-PieroCV 👋 I've started a review. Hopefully it will be merged soon 😄 |
Bug Description
In this PR #1023 I first corrected the arguments for the SubRouter HTTP methods (Get, Post etc) as they were out of sync with the Robyn class - they did not have the auth_required argument.
I'm now pretty sure that there is a problem in
Robyn.configure_authentication
When a SubRouter is created the authentication_handler is none. However,Robyn.configure_authentication
does not seem to set the authentication_handler for the SubRoutes, I'm also not sure if it is doing so for websockets or openapi endpoints (or even if it should)That highlighted multiple testing issues
pytest integration_tests
topytest
it still runs all the integration tests but also the unit tests.The text was updated successfully, but these errors were encountered: