Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trending EE plot normalization issue #677

Closed
mperrin opened this issue May 31, 2023 · 0 comments · Fixed by #688
Closed

Trending EE plot normalization issue #677

mperrin opened this issue May 31, 2023 · 0 comments · Fixed by #688
Assignees
Labels
bug Something isn't working JWST Affects JWST models in WebbPSF

Comments

@mperrin
Copy link
Collaborator

mperrin commented May 31, 2023

Reported by @mlibralato:

I'm studying the temporal variations of the ePSFs. I took the code in WebbPSF that show how the encircled energy varies over time and I correlated it with by how much my ePSFs seem to vary over time. I do not see any significant change, as I was told should be at this wavelengths. The comment here is that the code that makes this plot here (https://webbpsf.readthedocs.io/en/latest/jwst_measured_opds.html#Wavefront-Trending-throughout-a-given-month) computes the change in the encircled energy as EE_ref - EE_date but this is not a % change, so the shadowed box that highlight the +/-3% variations is not correct. Do you agree? I believe that to be consistent the plot should show on the y axis something like (EE_ref-EE_date)/EE_ref

@mperrin mperrin added bug Something isn't working JWST Affects JWST models in WebbPSF labels May 31, 2023
@obi-wan76 obi-wan76 self-assigned this Jun 15, 2023
Skyhawk172 added a commit to Skyhawk172/webbpsf that referenced this issue Jul 21, 2023
@Skyhawk172 Skyhawk172 self-assigned this Jul 21, 2023
@Skyhawk172 Skyhawk172 linked a pull request Jul 21, 2023 that will close this issue
BradleySappington pushed a commit to BradleySappington/webbpsf that referenced this issue Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JWST Affects JWST models in WebbPSF
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants