Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings while updating catkit conda environment #99

Open
asahooexo opened this issue Jun 8, 2023 · 3 comments
Open

Compiler warnings while updating catkit conda environment #99

asahooexo opened this issue Jun 8, 2023 · 3 comments

Comments

@asahooexo
Copy link
Contributor

Here is the screenshot of the terminal. I got two warnings when I updated the environment.

Screen Shot 2023-06-08 at 5 57 29 PM
@ehpor
Copy link
Collaborator

ehpor commented Jun 14, 2023

@RemiSoummer FYI

@raphaelpclt
Copy link
Collaborator

C++, seems to be an actual bug.

@ehpor
Copy link
Collaborator

ehpor commented Oct 9, 2024

Since properties have to be a Value object, they have to be either a float64 or a int64 type. These are the only types listed there. However, there should be a default clause that is hit when a different type somehow is passed. This is easy to implement.

In practice, the dtype validity is checked when creating the property with the stream, so it is practically impossible to have a stream-backed property with the wrong type, but strictly speaking there still should be a default return path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants