Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB] Images of diffs aren't being generated #22

Open
Raeschen opened this issue Jul 13, 2023 · 6 comments
Open

[MDB] Images of diffs aren't being generated #22

Raeschen opened this issue Jul 13, 2023 · 6 comments

Comments

@Raeschen
Copy link

I tested this on two different repos. The diff generates, but images (including raw links) are invalid.

All of Old - New - Diff, both the in-github preview and the raw link.

@AffectedArc07
Copy link
Member

Link a PR please. Theres a chance this happened during me testing something,

@Raeschen
Copy link
Author

a few:
CHOMPStation2/CHOMPStation2#6570
CHOMPStation2/CHOMPStation2#6568
CHOMPStation2/CHOMPStation2#6556

seems to of started happening very recently, past 2 days or so.

@Raeschen
Copy link
Author

Additionally, as visible in this check;
https://github.com/CHOMPStation2/CHOMPStation2/pull/6570/checks?check_run_id=15038956772

One mapcheck failed, despite me fixing this error. And then, all of the diff generations after that have been shifted up.
For example, the image content of 'cabinisland' is actually shown in 'southern-cross-8', illustrated below;
image

@Aquizit
Copy link

Aquizit commented Jul 19, 2023

@AffectedArc07
Copy link
Member

CC @jupyterkat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants