Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix arachnid lungs #34381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix arachnid lungs #34381

wants to merge 1 commit into from
+1 −1

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Jan 11, 2025

About the PR

change arachnid lungs from animal to arachnid

Why / Balance

fixes #34364

Technical details

no

Media

no

Requirements

Breaking changes

Changelog

🆑

  • fix: Arachnids now have actual arachnid lungs, instead of animal.

@lzk228 lzk228 requested a review from DrSmugleaf as a code owner January 11, 2025 14:33
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 11, 2025
@themias
Copy link
Contributor

themias commented Jan 11, 2025

I see in the original PR, the lungs are meant to use more oxygen. #18177
However, the lungs use an update interval, similar to what was removed recently from arachnid stomachs. #34298

Do we need to update how the lungs work to achieve the desired effect?

@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Character/Species Area: Player characters and species features and content. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arachnid Lungs problem
3 participants
@lzk228 @themias @ScarKy0