Drink entities and reactions need updating and a cleanup #34333
Labels
A: Service
Area: Service department, including cooking, botany, etc
D3: Low
Difficulty: Some codebase knowledge required.
Issue: Replicated
This issue has been replicated by another user.
P3: Standard
Priority: Default priority for repository items.
S: Requires Content PR
Status: Requires a change to SS14, for which there is no open PR currently.
T: New Feature
Type: New feature or content, or extending existing content
T: Visual Change
Type: Deals with changes to art, sprites or other visuals in the game.
Description
Many drink entity prototypes have values and components that are inconsistent. Some drinks are listed in the wrong files.
Reproduction
Have a look at the soda dispenser and try things like seeing which bottles or cartons leave trash or not, or have layers for different states.
Screenshots
Many more examples than just this.
Additional context
Jugs/Cartons in drinks_bottles could be moved to drinks-cartons (and I suppose that should probably be renamed to drink_cartons at some point). Jugs were also made as a temporary solution to not having carton sprites, but for some reason doubled in volume or reagent stored. Lots of drink containers don't leave trash, when others in the same container types do. The list goes on...
I'll start making a list, and add to it as I remember things I noticed:
drinks_bottles
could be moved todrinks-cartons
Reactions\drinks.yml
could be streamlined minimise an uneccasarily esoteric selection of required ingredientsThe text was updated successfully, but these errors were encountered: