Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drink entities and reactions need updating and a cleanup #34333

Open
11 tasks
Alpaccalypse opened this issue Jan 9, 2025 · 1 comment
Open
11 tasks

Drink entities and reactions need updating and a cleanup #34333

Alpaccalypse opened this issue Jan 9, 2025 · 1 comment
Labels
A: Service Area: Service department, including cooking, botany, etc D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.

Comments

@Alpaccalypse
Copy link
Contributor

Alpaccalypse commented Jan 9, 2025

Description

Many drink entity prototypes have values and components that are inconsistent. Some drinks are listed in the wrong files.

Reproduction
Have a look at the soda dispenser and try things like seeing which bottles or cartons leave trash or not, or have layers for different states.

Screenshots
Many more examples than just this.
image

Additional context
Jugs/Cartons in drinks_bottles could be moved to drinks-cartons (and I suppose that should probably be renamed to drink_cartons at some point). Jugs were also made as a temporary solution to not having carton sprites, but for some reason doubled in volume or reagent stored. Lots of drink containers don't leave trash, when others in the same container types do. The list goes on...

I'll start making a list, and add to it as I remember things I noticed:

  • Bottle and jug refills for the soda machine vary wildly in size and availability (being addressed in Bottled drinks and dispensers standardised #34338)
  • What drinks can be dispensed are somewhat arbitrary (also being addressed in above PR)
  • Some drink reactions could probably do with some rebalancing of reactants and final products
  • Some drink products heavily cross-over or don't make much sense, Hooch and Moonshine for instance
  • Drink IDs that vary wildly from their names and uses could be updated, some file names could be improved
  • Some .yml files with long lists could do with organising entries in a more logical order
  • All of the XL cartons and related jugs in drinks_bottles could be moved to drinks-cartons
  • Reactions\drinks.yml could be streamlined minimise an uneccasarily esoteric selection of required ingredients
  • A few cocktails have RL names but don't reflect the recipes for those, e.g. Snow White, Atomic Bomb
  • This is subjective; I think there should be more in-universe cocktails, like we have with soda brands
  • Reagent fill levels and glass volumes could do with some balancing, example in Absinthe makes you mildly hallucinate #34371
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jan 9, 2025
@Alpaccalypse
Copy link
Contributor Author

Alpaccalypse commented Jan 9, 2025

I'm actually working on this, but I noticed so much along the way that I realised it should probably be a few different PRs, and that it was going to take me quite a while before I have a PR ready. I thought I may as well post the issue, as much as a reminder for me, as for anyone else who is thinking of taking a stab at this. And it seems like quite a large and legitimate issue anyway.

I thought I'd already seen an issue posted about this, but I couldn't find anything.

@Alpaccalypse Alpaccalypse changed the title Drink entities need updating and a cleanup Drink entities and reactions need updating and a cleanup Jan 10, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. A: Service Area: Service department, including cooking, botany, etc T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

No branches or pull requests

2 participants