From cefe5afe4260e0fef8ac298b82cea96919fb3f11 Mon Sep 17 00:00:00 2001
From: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Date: Sat, 15 Jun 2024 02:38:35 +0200
Subject: [PATCH] Deleting old accounts is now a scheduled job.

---
 .../Config/AccountConfiguration.cs            |  9 ++++++
 SS14.Auth.Shared/StartupHelpers.cs            |  1 +
 .../Jobs/DeleteUnconfirmedAccountsJob.cs      | 32 +++++++++++++++++++
 SS14.Auth/Startup.cs                          |  5 +++
 4 files changed, 47 insertions(+)
 create mode 100644 SS14.Auth.Shared/Config/AccountConfiguration.cs
 create mode 100644 SS14.Auth/Jobs/DeleteUnconfirmedAccountsJob.cs

diff --git a/SS14.Auth.Shared/Config/AccountConfiguration.cs b/SS14.Auth.Shared/Config/AccountConfiguration.cs
new file mode 100644
index 0000000..b326aac
--- /dev/null
+++ b/SS14.Auth.Shared/Config/AccountConfiguration.cs
@@ -0,0 +1,9 @@
+namespace SS14.Auth.Shared.Config;
+
+public sealed class AccountConfiguration
+{
+    /// <summary>
+    /// Delete unconfirmed accounts after this many days.
+    /// </summary>
+    public int DeleteUnconfirmedAfter { get; set; } = 3;
+}
\ No newline at end of file
diff --git a/SS14.Auth.Shared/StartupHelpers.cs b/SS14.Auth.Shared/StartupHelpers.cs
index 75f08e6..b8594bc 100644
--- a/SS14.Auth.Shared/StartupHelpers.cs
+++ b/SS14.Auth.Shared/StartupHelpers.cs
@@ -28,6 +28,7 @@ public static void AddShared(IServiceCollection services, IConfiguration config)
         services.Configure<MutexOptions>(config.GetSection("Mutex"));
         services.Configure<PatreonConfiguration>(config.GetSection("Patreon"));
         services.Configure<AccountLogRetentionConfiguration>(config.GetSection("AccountLogRetention"));
+        services.Configure<AccountConfiguration>(config.GetSection("Account"));
         services.Configure<SecurityStampValidatorOptions>(options =>
         {
             // The fact that this isn't default absolutely baffles me.
diff --git a/SS14.Auth/Jobs/DeleteUnconfirmedAccountsJob.cs b/SS14.Auth/Jobs/DeleteUnconfirmedAccountsJob.cs
new file mode 100644
index 0000000..f13a191
--- /dev/null
+++ b/SS14.Auth/Jobs/DeleteUnconfirmedAccountsJob.cs
@@ -0,0 +1,32 @@
+using System;
+using System.Linq;
+using System.Threading.Tasks;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
+using Quartz;
+using SS14.Auth.Shared.Config;
+using SS14.Auth.Shared.Data;
+
+namespace SS14.Auth.Jobs;
+
+public sealed class DeleteUnconfirmedAccounts(ApplicationDbContext dbContext,
+    ILogger<DeleteUnconfirmedAccounts> logger,
+    IOptions<AccountConfiguration> configuration) : IJob
+{
+    public async Task Execute(IJobExecutionContext context)
+    {
+        var optionsValue = configuration.Value;
+
+        var retainMinimum = DateTime.UtcNow - TimeSpan.FromDays(optionsValue.DeleteUnconfirmedAfter);
+
+        // TODO: Use ExecuteDelete() on newer EF Core version.
+        var accounts = await dbContext.Users
+            .Where(user => !user.EmailConfirmed && user.CreatedTime < retainMinimum)
+            .ToListAsync(context.CancellationToken);
+
+        dbContext.RemoveRange(accounts);
+        await dbContext.SaveChangesAsync();
+        logger.LogInformation("Deleted {Count} unconfirmed accounts from database", accounts.Count);
+    }
+}
\ No newline at end of file
diff --git a/SS14.Auth/Startup.cs b/SS14.Auth/Startup.cs
index 342203b..817196e 100644
--- a/SS14.Auth/Startup.cs
+++ b/SS14.Auth/Startup.cs
@@ -61,6 +61,11 @@ public void ConfigureServices(IServiceCollection services)
                 {
                     schedule.RepeatForever().WithIntervalInHours(24);
                 }));
+
+                q.ScheduleJob<DeleteUnconfirmedAccounts>(trigger => trigger.WithSimpleSchedule(schedule =>
+                {
+                    schedule.RepeatForever().WithIntervalInHours(24);
+                }));
             }
         });
         services.AddQuartzHostedService();