Grab commit history from PR branch to support forks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum
force-pushed
the
check-fork-check
branch
3 times, most recently
from
e450a85 to
5c21859
Compare
eholum
changed the title
eholum
force-pushed
the
check-fork-check
branch
from
993d72f to
6e1f20d
Compare
eholum
changed the title
EzraBrooks
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3.
I guess we could always add the forked remote and fetch history there, too, but maybe this is cleaner? Unfortunately I can't just grab the HEAD of the
GITHUB_REFbecause it includes the simulated merge commit, which obviously fails.Thoughts?
This seems to work fine both from this fork and the primary repo: https://github.com/space-ros/check-commit-message-action/pull/5/checks