New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`MultiCollection::load_set_of_paths` uses different loading code/error handling than `from_zipfile` #543

Open

ctb opened this issue Dec 14, 2024 · 0 comments

Collaborator

ctb commented Dec 14, 2024

More needs to be said here, but in brief:

when loading a bad zipfile (in particular a .sig/.sig.gz misnamed as a zip), we get different error messages/results when using the main load function from_zipfile vs load_set_of_paths
this means some things work when they are specified on the command line, but not when provided in a standalone manifest

ref sourmash-bio/sourmash#3430 where we are now trying to propagate zip file loading errors properly.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment