fix: removed panics from acp check

jsimnz · jsimnz · commit 99ff24fdc395 · 2024-01-23T01:06:38.000-05:00
diff --git a/x/acp/keeper/msg_server_check_access.go b/x/acp/keeper/msg_server_check_access.go
@@ -43,11 +43,11 @@ func (k msgServer) CheckAccess(goCtx context.Context, msg *types.MsgCheckAccess)
 
 	creatorAddr, err := sdk.AccAddressFromBech32(msg.Creator)
 	if err != nil {
-		panic("creator must exist")
+		return nil, types.ErrInvalidAccAddr
 	}
 	creatorAcc := k.accountKeeper.GetAccount(ctx, creatorAddr)
 	if creatorAcc == nil {
-		panic("creator must exist")
+		return nil, types.ErrAccNotFound
 	}
 
 	cmd := access_decision.EvaluateAccessRequestsCommand{

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,11 @@ func (k msgServer) CheckAccess(goCtx context.Context, msg *types.MsgCheckAccess)`
`43`	`43`
`44`	`44`	`creatorAddr, err := sdk.AccAddressFromBech32(msg.Creator)`
`45`	`45`	`if err != nil {`
`46`		`- panic("creator must exist")`
	`46`	`+ return nil, types.ErrInvalidAccAddr`
`47`	`47`	`}`
`48`	`48`	`creatorAcc := k.accountKeeper.GetAccount(ctx, creatorAddr)`
`49`	`49`	`if creatorAcc == nil {`
`50`		`- panic("creator must exist")`
	`50`	`+ return nil, types.ErrAccNotFound`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`cmd := access_decision.EvaluateAccessRequestsCommand{`