Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GQL variables and operation name #2993

Merged
merged 8 commits into from
Sep 13, 2024

Merge branch 'develop' into nasdf/feat/gql-variables

0aa3a76
Select commit
Loading
Failed to load commit list.
Merged

feat: GQL variables and operation name #2993

Merge branch 'develop' into nasdf/feat/gql-variables
0aa3a76
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 13, 2024 in 0s

79.41% (+0.17%) compared to 36fb5b5

View this Pull Request on Codecov

79.41% (+0.17%) compared to 36fb5b5

Details

Codecov Report

Attention: Patch coverage is 91.26984% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (36fb5b5) to head (0aa3a76).

Files with missing lines Patch % Lines
internal/request/graphql/parser/request.go 72.09% 7 Missing and 5 partials ⚠️
internal/request/graphql/parser/filter.go 77.78% 3 Missing and 1 partial ⚠️
internal/request/graphql/parser/query.go 94.81% 3 Missing and 1 partial ⚠️
cli/request.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2993      +/-   ##
===========================================
+ Coverage    79.24%   79.41%   +0.17%     
===========================================
  Files          328      329       +1     
  Lines        25209    25120      -89     
===========================================
- Hits         19976    19949      -27     
+ Misses        3795     3757      -38     
+ Partials      1438     1414      -24     
Files with missing lines Coverage Δ
client/db.go 100.00% <100.00%> (ø)
http/client.go 57.20% <100.00%> (+1.23%) ⬆️
http/handler_store.go 85.25% <100.00%> (+0.65%) ⬆️
internal/db/request.go 82.76% <100.00%> (ø)
internal/db/store.go 72.58% <100.00%> (+0.68%) ⬆️
internal/db/view.go 64.71% <100.00%> (ø)
internal/request/graphql/parser.go 89.83% <100.00%> (ø)
internal/request/graphql/parser/commit.go 87.23% <100.00%> (+5.14%) ⬆️
internal/request/graphql/parser/mutation.go 87.50% <100.00%> (+5.32%) ⬆️
internal/request/graphql/parser/subscription.go 86.21% <100.00%> (+9.06%) ⬆️
... and 6 more

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fb5b5...0aa3a76. Read the comment docs.