Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge retries can result in incorrect state #2718

Closed
nasdf opened this issue Jun 13, 2024 · 0 comments · Fixed by #2719
Closed

Merge retries can result in incorrect state #2718

nasdf opened this issue Jun 13, 2024 · 0 comments · Fixed by #2719
Assignees
@nasdf
Labels
area/db-system Related to the core system related components of the DB
Milestone
DefraDB v0.12

Comments

@nasdf
Copy link
Member

nasdf commented Jun 13, 2024

Found in #2700

When a merge transaction conflict occurs and a merge is retried, it does not account for new DAG heads, which can result in an incorrect state.
@nasdf nasdf added the area/db-system Related to the core system related components of the DB label Jun 13, 2024
@nasdf nasdf added this to the DefraDB v0.12 milestone Jun 13, 2024
@nasdf nasdf self-assigned this Jun 13, 2024
@nasdf nasdf mentioned this issue Jun 13, 2024
Merged
4 tasks
@nasdf nasdf closed this as completed in 07e431d Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/db-system Related to the core system related components of the DB
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

fix: Merge retry logic nasdf/defradb
1 participant
@nasdf