Skip to content

Commit 8db7dd7

Browse files
authored
Fix workspace resolution for non-server-side (#803)
That's what you get for restructuring. Also thank you go for allowing shadowing so silently 🙃
1 parent 4d5a398 commit 8db7dd7

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ All notable changes to `src-cli` are documented in this file.
1919

2020
### Removed
2121

22+
## 3.42.1
23+
24+
### Fixed
25+
26+
- Fixed an issue where no workspaces would be executed on after successful workspace resolution.
27+
2228
## 3.42.0
2329

2430
### Changed

cmd/src/batch_common.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ func executeBatchSpec(ctx context.Context, ui ui.ExecUI, opts executeBatchSpecOp
371371
ui.DeterminingWorkspacesSuccess(len(workspaces))
372372
} else {
373373
ui.ResolvingRepositories()
374-
repos, err := svc.ResolveRepositories(ctx, batchSpec, opts.flags.allowUnsupported, opts.flags.allowIgnored)
374+
repos, err = svc.ResolveRepositories(ctx, batchSpec, opts.flags.allowUnsupported, opts.flags.allowIgnored)
375375
if err != nil {
376376
if repoSet, ok := err.(batches.UnsupportedRepoSet); ok {
377377
ui.ResolvingRepositoriesDone(repos, repoSet, nil)
@@ -385,7 +385,7 @@ func executeBatchSpec(ctx context.Context, ui ui.ExecUI, opts executeBatchSpecOp
385385
}
386386

387387
ui.DeterminingWorkspaces()
388-
workspaces, err := svc.DetermineWorkspaces(ctx, repos, batchSpec)
388+
workspaces, err = svc.DetermineWorkspaces(ctx, repos, batchSpec)
389389
if err != nil {
390390
return err
391391
}

0 commit comments

Comments
 (0)