Skip to content

Commit cfe7081

Browse files
sjarmakclaude
andcommitted
fix: run_selected_tasks.sh Docker tag casing + Daytona env passthrough
Two fixes: 1. mktemp generates mixed-case suffixes in temp dir names (e.g., /tmp/mcp_task_XxYyZz). Harbor derives Docker image tags from these paths, but Docker requires all-lowercase repository names. Fix: rename temp dirs to lowercase after creation. 2. Harbor --env and --override-storage-mb flags were not passed through to harbor run commands, so HARBOR_ENV=daytona had no effect. Fix: add ${HARBOR_ENV:+--env} and ${DAYTONA_OVERRIDE_STORAGE:+--override-storage-mb} to both baseline and MCP harbor run invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0e9c0c7 commit cfe7081

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

configs/run_selected_tasks.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -591,13 +591,13 @@ _launch_task_pair() {
591591
local _df_artifact_bl="${abs_path}/environment/Dockerfile.artifact_baseline"
592592
local _df_artifact="${abs_path}/environment/Dockerfile.artifact_only"
593593
if [ -f "$_df_artifact_bl" ]; then
594-
_bl_temp_dir=$(mktemp -d "/tmp/bl_${task_id}_XXXXXX")
594+
_bl_temp_dir=$(_td=$(mktemp -d "/tmp/bl_${task_id}_XXXXXX") && _td_lower=$(echo "$_td" | tr '[:upper:]' '[:lower:]') && [ "$_td" != "$_td_lower" ] && mv "$_td" "$_td_lower"; echo "${_td_lower:-$_td}")
595595
cp -a "${abs_path}/." "${_bl_temp_dir}/"
596596
cp "$_df_artifact_bl" "${_bl_temp_dir}/environment/Dockerfile"
597597
_bl_task_path="$_bl_temp_dir"
598598
echo " [artifact-baseline] Using local-code artifact Dockerfile for baseline: $task_id"
599599
elif [ -f "$_df_artifact" ]; then
600-
_bl_temp_dir=$(mktemp -d "/tmp/bl_${task_id}_XXXXXX")
600+
_bl_temp_dir=$(_td=$(mktemp -d "/tmp/bl_${task_id}_XXXXXX") && _td_lower=$(echo "$_td" | tr '[:upper:]' '[:lower:]') && [ "$_td" != "$_td_lower" ] && mv "$_td" "$_td_lower"; echo "${_td_lower:-$_td}")
601601
cp -a "${abs_path}/." "${_bl_temp_dir}/"
602602
cp "$_df_artifact" "${_bl_temp_dir}/environment/Dockerfile"
603603
_bl_task_path="$_bl_temp_dir"
@@ -621,6 +621,8 @@ _launch_task_pair() {
621621
--jobs-dir "$bl_jobs_dir" \
622622
-n "$CONCURRENCY" \
623623
--timeout-multiplier "$TIMEOUT_MULTIPLIER" \
624+
${HARBOR_ENV:+--env "$HARBOR_ENV"} \
625+
${DAYTONA_OVERRIDE_STORAGE:+--override-storage-mb "$DAYTONA_OVERRIDE_STORAGE"} \
624626
2>&1 | tee -a "${bl_jobs_dir}.log" \
625627
|| echo "WARNING: $BASELINE_CONFIG failed: $task_id"
626628
) &
@@ -639,7 +641,7 @@ _launch_task_pair() {
639641
# Artifact mode: use Dockerfile.artifact_only (full repo + artifact sentinel)
640642
local _df_artifact="${abs_path}/environment/Dockerfile.artifact_only"
641643
if [ -f "$_df_artifact" ]; then
642-
_mcp_temp_dir=$(mktemp -d "/tmp/mcp_${task_id}_XXXXXX")
644+
_mcp_temp_dir=$(_td=$(mktemp -d "/tmp/mcp_${task_id}_XXXXXX") && _td_lower=$(echo "$_td" | tr '[:upper:]' '[:lower:]') && [ "$_td" != "$_td_lower" ] && mv "$_td" "$_td_lower"; echo "${_td_lower:-$_td}")
643645
cp -a "${abs_path}/." "${_mcp_temp_dir}/"
644646
cp "${_mcp_temp_dir}/environment/Dockerfile.artifact_only" "${_mcp_temp_dir}/environment/Dockerfile"
645647
_mcp_task_path="$_mcp_temp_dir"
@@ -651,7 +653,7 @@ _launch_task_pair() {
651653
# Direct mode: use Dockerfile.sg_only (empty workspace, agent uses MCP)
652654
local _df_sgonly="${abs_path}/environment/Dockerfile.sg_only"
653655
if [ -f "$_df_sgonly" ]; then
654-
_mcp_temp_dir=$(mktemp -d "/tmp/mcp_${task_id}_XXXXXX")
656+
_mcp_temp_dir=$(_td=$(mktemp -d "/tmp/mcp_${task_id}_XXXXXX") && _td_lower=$(echo "$_td" | tr '[:upper:]' '[:lower:]') && [ "$_td" != "$_td_lower" ] && mv "$_td" "$_td_lower"; echo "${_td_lower:-$_td}")
655657
cp -a "${abs_path}/." "${_mcp_temp_dir}/"
656658
cp "${_mcp_temp_dir}/environment/Dockerfile.sg_only" "${_mcp_temp_dir}/environment/Dockerfile"
657659
_mcp_task_path="$_mcp_temp_dir"
@@ -688,6 +690,8 @@ _launch_task_pair() {
688690
--jobs-dir "$full_jobs_dir" \
689691
-n "$CONCURRENCY" \
690692
--timeout-multiplier "$TIMEOUT_MULTIPLIER" \
693+
${HARBOR_ENV:+--env "$HARBOR_ENV"} \
694+
${DAYTONA_OVERRIDE_STORAGE:+--override-storage-mb "$DAYTONA_OVERRIDE_STORAGE"} \
691695
2>&1 | tee -a "${full_jobs_dir}.log" \
692696
|| echo "WARNING: $FULL_CONFIG failed: $task_id"
693697
) &

0 commit comments

Comments
 (0)