Skip to content

fix(web): don't grey out the Add connector button while creating#1265

Merged
msukkari merged 1 commit into
v5from
msukkari/fix-add-connector-button-disabled
Jun 3, 2026
Merged

fix(web): don't grey out the Add connector button while creating#1265
msukkari merged 1 commit into
v5from
msukkari/fix-add-connector-button-disabled

Conversation

@msukkari
Copy link
Copy Markdown
Contributor

@msukkari msukkari commented Jun 3, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5c45776-1fc2-4ebc-ae90-e8dcd9d2c4ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch msukkari/fix-add-connector-button-disabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

@msukkari your pull request is missing a changelog!

The "Add connector" trigger button was disabled via `disabled={isCreating}`,
which left it greyed out for a couple seconds after adding a connector while
the connector queries refetched. Drop the disabled state from the trigger
entirely — it only opens the create popover, and the in-dialog submit button
still guards against duplicate submissions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@msukkari msukkari force-pushed the msukkari/fix-add-connector-button-disabled branch from 24dbb4f to 1dd6fef Compare June 3, 2026 00:19
@msukkari msukkari changed the title fix(web): re-enable Add connector button without waiting on background refetch fix(web): don't grey out the Add connector button while creating Jun 3, 2026
@msukkari msukkari merged commit f4478cd into v5 Jun 3, 2026
3 checks passed
@msukkari msukkari deleted the msukkari/fix-add-connector-button-disabled branch June 3, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant