Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc is null if script is included in the head #50

Open
soulwire opened this issue Feb 12, 2014 · 0 comments · May be fixed by #67 or sc0ttj/sketch.js#5
Open

doc is null if script is included in the head #50

soulwire opened this issue Feb 12, 2014 · 0 comments · May be fixed by #67 or sc0ttj/sketch.js#5
Assignees
@soulwire
Labels
bug

Comments

@soulwire
Copy link
Owner

Should get refs to the document during the create cycle or otherwise when first needed
@soulwire soulwire added the bug label Feb 12, 2014
@soulwire soulwire self-assigned this Feb 12, 2014
@bitinn bitinn linked a pull request Feb 16, 2015 that will close this issue
Open
sc0ttj added a commit to sc0ttj/sketch.js that referenced this issue Mar 4, 2021
@sc0ttj
Fix dom ready issue
bc98b71 
Fix soulwire#50, by not using doc.body until Sketch.create() is called.

Note that you still need the DOM ready for Sketch.create() to work

from soulwire#67
@sc0ttj sc0ttj linked a pull request Mar 4, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulwire soulwire

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dom ready issue
Fix dom ready issue sc0ttj/sketch.js
1 participant
@soulwire