Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what values control certain elements when creating theme. #85

Closed
totallygeekdom opened this issue Jun 25, 2024 · 2 comments
Closed
Labels
wip Work in progress. No time table set.

Comments

@totallygeekdom
Copy link

I do think there is poor documentation on what variables affect what part of the UI. The names are unintuitive.
However, I was able to find out what most of the variables do. Although some still evade me, I am not sure what controls the color when hovering over the new tab button; for me, it looks like no color at all. Also, I do not know what controls the border and text of the tooltip. Do you by chance know where I can change these colors?

image

@soulhotel
Copy link
Owner

/*--tabs tooltip styling--*/
.tab-preview-container {
background-color: var(--uc-context-menu) !important;
color: var(--uc-light-dark) !important;
width: 225px !important;
border: 1px solid var(--uc-text) !important;
}

It's just this above.

I get what you're saying. I have been reorganizing the theme and considered making changes to the variable structure before, Ive seen the inconsistencies as well.. I'll include this task for the next update.

@soulhotel soulhotel added the wip Work in progress. No time table set. label Jun 30, 2024
@soulhotel
Copy link
Owner

Alright.

Color Variables have been adjusted; excess removed, readability improved (hopefully). Some changes include but are not limited to:

  • Name shortening from uc-ultima-etc to uc-etc for all.
  • uc-light-dark and uc-dark-light removed/merged into uc-text. Functionality has not changed but it shouldn't have been applied to fields that aren't text..
  • uc-panel-border is utilized more often, specifically for every element that has a modified border.
  • uc-background-tabs, uc-background-panels - background variables are a bit more specific, being applied to their related element.
  • Many nested elements (with altered backgrounds) now adopt their parents related background variable.

These changes will be slated for the update tomorrow and already viewable on the main-update-branch, but I'm sure there is more that can be improved in due time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress. No time table set.
Projects
None yet
Development

No branches or pull requests

2 participants