docs: Update readme to avoid label issue #168
Conversation
|
@jfagoagas I have gotten the version to work in which the label checking is performed in a different job: Imo that is a bit more elegant as it requires less ifs. Also, I think doing label checks with that action is more readable than native GA code. So maybe we could simply insert a second step for the label checker that checks the non-allowed labels in non-prefix mode and then combine the result of these two into a single output that can then be used to conditionally enable the actual backport action (together with the merge condition)? |
That's super clean 💯
That'd be ideal, you can jump into my forked repo branch to included it in this PR. Thanks 🙌 |
Context
Fixes #127
Description
Update
README.mdto avoid the action to run if the PR contains the labelsbackportorwas-backported. Also it uses thepull-request-label-checkeraction just to run if the PR contains thebackport-to-label prefix.The reason behind the change is due to the fact that the action needs to run when all of the following happens:
ifat thejoblevel.backport-> Done with theifat thejoblevel.was-backported-> Done with theifat thejoblevel.backport-to(or the tag of your choice) -> Done with thepreview_label_checkstep.