Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: LazyConnectionDataSourceProxy 적용 #519

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor: LazyConnectionDataSourceProxy 적용 #519

wants to merge 2 commits into from
+27 −2

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Dec 28, 2024

👩‍💻 Contents

  • LazyConnectionDataSourceProxy 를 적용했습니다.
  • 관련해서 블로그로 정리했습니다. cc. https://gamxong.tistory.com/156#toc2
  • 실제 엄청난 성능개선을 하진 못했지만 다른 API 에선 성능 개선을 시도해볼만 한 것 같아 제안드려보고 싶습니다!

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@mikekks mikekks added the 🛠️ refactor 리팩토링 및 개선 label Dec 28, 2024
@mikekks mikekks requested a review from hoonyworld December 28, 2024 12:51
@mikekks mikekks self-assigned this Dec 28, 2024
@height Height
Copy link

height bot commented Dec 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoonyworld hoonyworld Awaiting requested review from hoonyworld

At least 1 approving review is required to merge this pull request.

Assignees

@mikekks mikekks

Labels
🛠️ refactor 리팩토링 및 개선 size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: LazyConnectionDataSourceProxy 고려
1 participant
@mikekks